Skip to content

refactor(core): improve docstrings for HTML link extraction utilities #34550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdrxy merged 1 commit into from
Jan 8, 2026
Merged

refactor(core): improve docstrings for HTML link extraction utilities #34550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/core/langchain_core/utils/html.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def find_all_links(
pattern: Regex to use for extracting links from raw HTML.

Returns:
all links
A list of all links found in the HTML.
"""
pattern = pattern or DEFAULT_LINK_REGEX
return list(set(re.findall(pattern, raw_html)))
Expand Down Expand Up @@ -73,7 +73,7 @@ def extract_sub_links(
exception. Otherwise, raise the exception.

Returns:
sub links.
A list of absolute paths to sub links.
"""
base_url_to_use = base_url if base_url is not None else url
parsed_base_url = urlparse(base_url_to_use)
Expand Down