chore(langchain): activate mypy warn-unreachable #34553
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
langchain
cbornet
commented
Dec 31, 2025
| # type narrowing not working appropriately w/ callable check, can fix later | ||
| return True, handle_errors(exception) # type: ignore[return-value,call-arg] | ||
| return False, "" | ||
| return True, handle_errors(exception) |
Collaborator
Author
There was a problem hiding this comment.
type narrowing now works because handle_errors cannot be a type anymore at this stage.
Note that type is callable.
cbornet
commented
Dec 31, 2025
| if not _HAS_RESOURCE: # pragma: no cover - defensive | ||
| return | ||
| pid = process.pid | ||
| if pid is None: |
Collaborator
Author
There was a problem hiding this comment.
subprocess.Popen.pid is never None.
Is it OK ?
cbornet
commented
Dec 31, 2025
| system_prompt: str | SystemMessage | None = None, | ||
| middleware: Sequence[AgentMiddleware[StateT_co, ContextT]] = (), | ||
| response_format: ResponseFormat[ResponseT] | type[ResponseT] | None = None, | ||
| response_format: ResponseFormat[ResponseT] | type[ResponseT] | dict[str, Any] | None = None, |
Collaborator
Author
There was a problem hiding this comment.
According to test_json_schema, create_agent's response_format can be a dict.
Which means it has to be supported in AutoStrategy/ToolStrategy/ProviderStrategy/_SchemaSpec
cbornet
commented
Dec 31, 2025
| content = message.content | ||
| if isinstance(content, str): | ||
| return content | ||
| if isinstance(content, list): |
Collaborator
Author
There was a problem hiding this comment.
BaseMessage.content is either a str or a list.
So there should be no need to have a fallback.
cbornet
force-pushed
the
langchain-warn-unreachable
branch
from
d559b93 to
67ee999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.