fix(core): inject additional kwargs into BaseTool _run and _arun
#34561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug in
BaseToolwhere additionalkwargs(such asToolRuntimeor system-injected arguments) were not being passed to the internal_runand_arunmethods. The execution logic now correctly inspects the function signature and injects matching arguments from the providedkwargs.Fixes
Fixes #34558
Validation
ToolRuntimeis now correctly injected.libs/core/tests/unit_tests/test_tools.pypassed.make formatandmake lintinlibs/core.Generative AI Disclaimer
I used Gemini to assist in identifying the logic gap in
base.py, formulating the reproduction script, and drafting this PR description.