Skip to content

Conversation

@cbornet
Copy link
Collaborator

@cbornet cbornet commented Jan 1, 2026

description by @mdrxy

  • Enable test_responses_spec.py integration tests that were previously skipped at module level
  • Widen ToolStrategy.schema type annotation from type[SchemaT] to type[SchemaT] | dict[str, Any] to match actual supported usage (JSON schema dicts were already handled at runtime)
  • Fix type annotations and linting issues in test file (modernize to dict/list, add return types, prefix unused _request param)
  • Improve generic typing in load_spec utility with bounded TypeVar

@github-actions github-actions bot added langchain `langchain` package issues & PRs dependencies Pull requests that update a dependency file (e.g. `pyproject.toml` or `uv.lock`) tests PRs made that add, modify, or remove tests labels Jan 1, 2026
@cbornet cbornet changed the title test(langchain): complete and activate test_responses_spec tests test(langchain): activate test_responses_spec tests Jan 1, 2026
@github-actions github-actions bot added tests PRs made that add, modify, or remove tests and removed tests PRs made that add, modify, or remove tests labels Jan 1, 2026
@cbornet cbornet force-pushed the langchain-test_responses_spec branch 2 times, most recently from b822fdf to af1f921 Compare January 1, 2026 12:46
@cbornet cbornet force-pushed the langchain-test_responses_spec branch from af1f921 to ddecd14 Compare January 1, 2026 12:49
@mdrxy mdrxy changed the title test(langchain): activate test_responses_spec tests test(langchain): activate test_responses_spec tests Jan 9, 2026
@mdrxy mdrxy self-assigned this Jan 9, 2026
@github-actions github-actions bot added tests PRs made that add, modify, or remove tests and removed tests PRs made that add, modify, or remove tests labels Jan 9, 2026
@github-actions github-actions bot added tests PRs made that add, modify, or remove tests and removed tests PRs made that add, modify, or remove tests labels Jan 9, 2026
@mdrxy mdrxy merged commit 9ce73a7 into langchain-ai:master Jan 9, 2026
53 checks passed
@cbornet cbornet deleted the langchain-test_responses_spec branch January 10, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file (e.g. `pyproject.toml` or `uv.lock`) langchain `langchain` package issues & PRs tests PRs made that add, modify, or remove tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants