Skip to content

Conversation

@cbornet
Copy link
Collaborator

@cbornet cbornet commented Jan 1, 2026

  • Making FakeToolCallingModel generic on its structured_response doesn't help anywhere in typing.
  • There are more than 120 references of FakeToolCallingModel in the code where you get error: Need type annotation for "model" [var-annotated] because mypy can't resolve the generic type (we don't see them atm because they are in files temporarily excluded from mypy checking). We would need to explicitly type them to FakeToolCallingModel[Any]

@github-actions github-actions bot added langchain `langchain` package issues & PRs infra PRs made that include chores, devops, repo meta changes and removed infra PRs made that include chores, devops, repo meta changes labels Jan 1, 2026
@mdrxy mdrxy added the typing label Jan 4, 2026
@cbornet cbornet force-pushed the FakeToolCallingModel-no-generic branch 2 times, most recently from 6f9b0a0 to 7c55e57 Compare January 8, 2026 12:01
@cbornet cbornet force-pushed the FakeToolCallingModel-no-generic branch from 7c55e57 to e76e9bf Compare January 8, 2026 12:01
@github-actions github-actions bot added infra PRs made that include chores, devops, repo meta changes and removed infra PRs made that include chores, devops, repo meta changes labels Jan 8, 2026
@mdrxy mdrxy changed the title chore(langchain): remove generic from FakeToolCallingModel chore(langchain): remove generic from FakeToolCallingModel Jan 10, 2026
@github-actions github-actions bot added infra PRs made that include chores, devops, repo meta changes and removed infra PRs made that include chores, devops, repo meta changes labels Jan 10, 2026
@mdrxy mdrxy merged commit bfe0a26 into langchain-ai:master Jan 10, 2026
47 checks passed
@cbornet cbornet deleted the FakeToolCallingModel-no-generic branch January 10, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra PRs made that include chores, devops, repo meta changes langchain `langchain` package issues & PRs typing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants