feat(langchain): port AND-capable trigger conditions to SummarizationMiddleware
#34576
+464
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
langchain
Davda-James
changed the title
github-actions
bot
added
feature
mdrxy
changed the title
SummarizationMiddleware
github-actions
bot
removed
the
feature
Member
|
@Davda-James would you mind resolving conflicts? |
github-actions
bot
added
the
feature
Member
|
please also resolve CI failures |
Contributor
Author
|
yeah @mdrxy doing that, will add commit with fix. |
Refactor token threshold checks to improve clarity and logic.
Contributor
Author
done |
Contributor
Author
|
Hi @mdrxy, please let me know if any changes or improvements are needed from my side. Happy to update it accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR title: feat(langchain): AND capable trigger conditions in Python SummarizationMiddleware
PR description:
Add support for dict-style AND triggers to SummarizationMiddleware, so clauses like {"tokens": 4000, "messages": 10} require all thresholds to be met, while lists of such dicts remain OR across clauses. Maintains backward compatibility with tuple triggers, adds tests.
Once if change is confirmed to be merged, will add docs accordingly.
Files Changed
Checklist
make format,make lintandmake testfrom the langchain_v1/Closes Issue: #34442