Skip to content

Conversation

@ccurme
Copy link
Collaborator

@ccurme ccurme commented Jan 9, 2026

Following #34599, we no longer error on schemas when all arguments have defaults and strict is enabled.

@ccurme ccurme requested a review from mdrxy as a code owner January 9, 2026 16:27
@github-actions github-actions bot added integration PR made that is related to a provider partner package integration openai `langchain-openai` package issues & PRs infra PRs made that include chores, devops, repo meta changes labels Jan 9, 2026
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 9, 2026

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing cc/delete_openai_test (10878d4) with master (c080296)1

Summary

✅ 6 untouched benchmarks
⏩ 28 skipped benchmarks2

Footnotes

  1. No successful run was found on master (d972d00) during the generation of this report, so c080296 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

  2. 28 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@ccurme ccurme merged commit 19edaa8 into master Jan 9, 2026
83 checks passed
@ccurme ccurme deleted the cc/delete_openai_test branch January 9, 2026 17:37
@mdrxy mdrxy added the internal label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra PRs made that include chores, devops, repo meta changes integration PR made that is related to a provider partner package integration internal openai `langchain-openai` package issues & PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants