-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(community): For IBM implementation rename variables, remove defaults, fix tests and minor docs fixes #7129
base: main
Are you sure you want to change the base?
fix(community): For IBM implementation rename variables, remove defaults, fix tests and minor docs fixes #7129
Conversation
- rename variables to camelCase - remove default values for model - Update and remove some tests - update urls in documentation, shrink outputs
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Fix docs, update urls
@jacoblee93 Could you please have a look at it or assign someone to this PR? Thank you |
Happy to merge since this is a newer integration but noting that this is breaking |
Looks like you need to update your notebooks, they are failing our CI check:
|
I fixed the failing notebook |
Now failing lint and:
|
I am just fixing the notebooks but lint doesn't seem to be a problem with our implementation:
|
* Fix notebook * Fix passing params
CC @bracesproul above |
* Fix notebook * Fix passing params * Fix embedding notebook
Deployment failed with the following error:
|
Following PR provides following fixes: