-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: Windows compatibility and documentation typos #9085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
NiranjanKumar001
commented
Sep 30, 2025
- Fix Windows build compatibility in @langchain/scripts package
- Replace Unix-specific mkdir -p and mv commands with Node.js equivalents
- Replace rm -rf with cross-platform rimraf
- Fix typo: 'Langhain' -> 'LangChain' in README files
- Fix typos in net-mocks README: 'occured' -> 'occurred', 'its the' -> 'it's the'"
- Fix Windows build compatibility in @langchain/scripts package - Replace Unix-specific mkdir -p and mv commands with Node.js equivalents - Replace rm -rf with cross-platform rimraf - Fix typo: 'Langhain' -> 'LangChain' in README files - Fix typos in net-mocks README: 'occured' -> 'occurred', 'its the' -> 'it's the'
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
"build": "yarn clean && yarn turbo:command build:internal --filter=@langchain/scripts", | ||
"build:internal": "tsc --project ./tsconfig.build.json && yarn move:artifacts && yarn build:generated", | ||
"move:artifacts": "rimraf dist && mkdir -p dist && mv dist_build/* dist/", | ||
"move:artifacts": "rimraf dist && node -e \"const fs = require('fs'); fs.mkdirSync('dist', {recursive: true}); fs.cpSync('dist_build', 'dist', {recursive: true});\"", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are using rimraf
, let's be consistent and also use mkdirp
from NPM for this.
@NiranjanKumar001 is attempting to deploy a commit to the LangChain Team on Vercel. A member of the Team first needs to authorize it. |