Skip to content

Conversation

pokey
Copy link

@pokey pokey commented Oct 3, 2025

Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: 197da64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 3, 2025

@pokey is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
langchainjs-docs Error Error Oct 3, 2025 2:38pm

@pokey
Copy link
Author

pokey commented Oct 3, 2025

Do we want an integration test?

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@christian-bromann
Copy link
Member

Do we want an integration test?

If you can come up with an easy one that validates the functionality and is stable, let's do it!

Copy link
Member

@hntrl hntrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an integration test would be handy! And because this is a new feature add it would be good to add a changeset

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am fine to keep this, but as commentary I'm not sure how much benefit we get from testing invocationParams directly (it's only part of the messages + options -> sdk payload "chain")

ideal state is the conversion logic of messages + options is collapsed into something like getRequestPayload and that's what we test (this is how python does it iirc). Not needed for this PR though.

ok I'll get off my soap box now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants