Skip to content

Conversation

pokey
Copy link

@pokey pokey commented Oct 3, 2025

This allows us to pass things like headers and container to the model call

Copy link

changeset-bot bot commented Oct 3, 2025

⚠️ No Changeset found

Latest commit: b6feeaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 3, 2025

@pokey is attempting to deploy a commit to the LangChain Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Oct 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Updated (UTC)
langchainjs-docs Ignored Ignored Oct 7, 2025 10:59am

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Let's sync with the Python team on the new property on ModelRequest

@pokey
Copy link
Author

pokey commented Oct 7, 2025

As discussed with @eyurtsev, we're holding off on merging this one until we look into Python version

/**
* Extra call options to pass to the model.
*/
callOptions?: Record<string, unknown>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @christian-bromann / @pokey is this a standard name in js?

@sydney-runkle this is extra config that we'll be passing to chat model invoke. We can either use the same standard name if it makes sense or follow whatever is convention in each language.

  • extra_params
  • invoke_kwargs

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be more specific here I would suggest modelCallOptions as an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants