Skip to content

Conversation

@promentol
Copy link

Added semantic text splitter, similar to python version
I put the file in experimental folder, as in python version it is still in langchain_experimental package

solves this https://github.com/langchain-ai/langchainjs/discussions/7147

Do we need to update documentation too, if approved?

@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2025

⚠️ No Changeset found

Latest commit: 619839c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
langchainjs-api-refs Ignored Ignored Oct 14, 2025 9:19am
langchainjs-docs Ignored Ignored Oct 14, 2025 9:19am

@hntrl
Copy link
Member

hntrl commented Oct 14, 2025

Hey @promentol! Thanks for the change

I'll call out that we're about to merge v1, which significantly alters the package structure of langchain. Would you mind rebasing your changes onto there, and fitting this into libs/langchain-textsplitters? (we aren't exporting text splitters from the langchain package anymore)

@promentol promentol changed the base branch from main to v1 October 15, 2025 01:33
@promentol promentol changed the base branch from v1 to main October 15, 2025 01:34
@promentol
Copy link
Author

@hntrl Thank you for feedback, I am closing this PR and issued new one for v1 branches

#9199

@promentol promentol closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants