-
Notifications
You must be signed in to change notification settings - Fork 8.4k
feat: Transform sticky notes to compact 260x100px rectangles #10149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
406da41
feat: Transform sticky notes to compact 260x100px rectangles
rodrigosnader afa5d3e
[autofix.ci] apply automated fixes
autofix-ci[bot] 7de02d6
merged main
deon-sanchez 0f4bec9
revert stp
deon-sanchez e9e1e16
increase size to 280x140 and gh suggestions
Cristhianzl ca315d1
merge fix
Cristhianzl dc213d7
add padding
Cristhianzl efedee4
merge fix
Cristhianzl de0f795
Merge branch 'main' into feature/compact-sticky-notes
Cristhianzl 44507eb
Merge branch 'main' into feature/compact-sticky-notes
Cristhianzl 3692deb
fix tests jest
Cristhianzl dd69423
[autofix.ci] apply automated fixes
autofix-ci[bot] f8dcebb
fix tests sticky notes
Cristhianzl dbdf1ec
Merge branch 'feature/compact-sticky-notes' of github.com:langflow-ai…
Cristhianzl 1ae093f
Merge branch 'main' into feature/compact-sticky-notes
Cristhianzl 6b56ea8
[autofix.ci] apply automated fixes
autofix-ci[bot] 53849e9
add openai api key
Cristhianzl 43d740c
Merge branch 'main' into feature/compact-sticky-notes
Cristhianzl d319a83
fix research translation loop
Cristhianzl 6c0bf05
Merge branch 'main' of github.com:langflow-ai/langflow into feature/c…
viktoravelino 8110420
Enhance scrollbar visibility for sticky notes
viktoravelino 99d36df
[autofix.ci] apply automated fixes
autofix-ci[bot] 7e5e684
Merge branch 'main' into feature/compact-sticky-notes
viktoravelino d59f1e3
Merge branch 'main' into feature/compact-sticky-notes
viktoravelino 8f0942f
fix: GitHub Actions explixitly set grep string
Adam-Aghili fdcf2fb
revert some files
viktoravelino 710ca2f
Merge branch 'feature/compact-sticky-notes' of github.com:langflow-ai…
viktoravelino 9eafb12
Merge branch 'main' into feature/compact-sticky-notes
viktoravelino 98a5bae
Merge branch 'main' into feature/compact-sticky-notes
viktoravelino e24090a
fix: Update outdated components test assertions for accuracy
viktoravelino ee6e4af
fix: Correct test selector for Chroma DB in tweaksTest.spec.ts
viktoravelino 6526688
Merge branch 'main' into feature/compact-sticky-notes
viktoravelino 796aa14
Merge branch 'main' into feature/compact-sticky-notes
viktoravelino File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 changes: 46 additions & 0 deletions
46
src/frontend/tests/core/unit/sticky-notes-constants.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { expect, test } from "../../fixtures"; | ||
|
|
||
| test( | ||
| "sticky notes constants should be properly defined", | ||
| { tag: ["@release", "@workspace"] }, | ||
|
|
||
| async ({ page }) => { | ||
| const constants = await page.evaluate(() => ({ | ||
| expectedMinWidth: 260, | ||
| expectedMinHeight: 100, | ||
| expectedMaxWidth: 1000, | ||
| expectedMaxHeight: 800, | ||
| })); | ||
|
|
||
| expect(constants.expectedMinWidth).toBe(260); | ||
| expect(constants.expectedMinHeight).toBe(100); | ||
| expect(constants.expectedMaxWidth).toBe(1000); | ||
| expect(constants.expectedMaxHeight).toBe(800); | ||
| }, | ||
| ); | ||
|
|
||
| test( | ||
| "sticky notes should use text-base font size", | ||
| { tag: ["@release", "@workspace"] }, | ||
|
|
||
| async ({ page }) => { | ||
| const textSize = await page.evaluate(() => { | ||
| const testEl = document.createElement("div"); | ||
| testEl.className = "text-base font-medium"; | ||
| testEl.style.visibility = "hidden"; | ||
| document.body.appendChild(testEl); | ||
|
|
||
| const style = window.getComputedStyle(testEl); | ||
| const result = { | ||
| fontSize: style.fontSize, | ||
| fontWeight: style.fontWeight, | ||
| }; | ||
|
|
||
| document.body.removeChild(testEl); | ||
| return result; | ||
| }); | ||
|
|
||
| expect(textSize.fontSize).toBe("16px"); | ||
| expect(textSize.fontWeight).toBe("400"); | ||
| }, | ||
|
Comment on lines
27
to
45
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Expect medium font weight (500).
🤖 Prompt for AI Agents |
||
| ); | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test never asserts the real constants.
page.evaluatejust returns literal numbers and the test asserts those same literals, so the test will keep passing even ifNOTE_NODE_MIN_WIDTH/HEIGHT/MAX_*change again. Import the constants (or read them from the built bundle) and compare against the expected values to give this test any value.🤖 Prompt for AI Agents