-
Notifications
You must be signed in to change notification settings - Fork 8.3k
fix: fix cleanEdges to work with group_outputs logic, make tests #10188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mfortman11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nicely done
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## release-1.6.5 #10188 +/- ##
================================================
Coverage ? 35.68%
================================================
Files ? 1221
Lines ? 58147
Branches ? 5549
================================================
Hits ? 20747
Misses ? 37239
Partials ? 161
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|



This pull request improves how custom component outputs are handled and tested in the flow editor, especially regarding grouped outputs and their persistence across page reloads. The main changes include refining the logic for matching and displaying outputs in
cleanEdges, and adding a comprehensive regression test to ensure output connections persist as expected for custom components with multiple outputs.Improvements to output handling logic:
cleanEdges(inreactflowUtils.ts) forgenericNodetypes to better handle grouped and non-grouped outputs, ensuring correct visibility and selection behavior for outputs with and without thegroup_outputsproperty.Testing and regression coverage:
general-bugs-clean-edges.spec.ts) that creates a custom component with multiple outputs (including grouped outputs), verifies correct UI rendering (separate outputs and dropdowns), tests connecting outputs to other components, and ensures that connections persist correctly after page reloads.