Skip to content

Conversation

@lucaseduoli
Copy link
Collaborator

This pull request improves how custom component outputs are handled and tested in the flow editor, especially regarding grouped outputs and their persistence across page reloads. The main changes include refining the logic for matching and displaying outputs in cleanEdges, and adding a comprehensive regression test to ensure output connections persist as expected for custom components with multiple outputs.

Improvements to output handling logic:

  • Refined the output matching logic in cleanEdges (in reactflowUtils.ts) for genericNode types to better handle grouped and non-grouped outputs, ensuring correct visibility and selection behavior for outputs with and without the group_outputs property.

Testing and regression coverage:

  • Added a new Playwright regression test (general-bugs-clean-edges.spec.ts) that creates a custom component with multiple outputs (including grouped outputs), verifies correct UI rendering (separate outputs and dropdowns), tests connecting outputs to other components, and ensures that connections persist correctly after page reloads.

@lucaseduoli lucaseduoli self-assigned this Oct 8, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/output_selection

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 8, 2025
@github-actions github-actions bot added the lgtm This PR has been approved by a maintainer label Oct 8, 2025
Copy link
Collaborator

@mfortman11 mfortman11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

Frontend Unit Test Coverage Report

Coverage Summary

Lines Statements Branches Functions
Coverage: 9%
9.58% (2522/26308) 3.9% (793/20313) 4.04% (229/5660)

Unit Test Results

Tests Skipped Failures Errors Time
831 0 💤 0 ❌ 0 🔥 14.467s ⏱️

@codecov
Copy link

codecov bot commented Oct 9, 2025

Codecov Report

❌ Patch coverage is 0% with 106 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-1.6.5@7125c60). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../components/NodeOutputParameter/nodeOutputUtils.ts 0.00% 61 Missing ⚠️
...ode/components/NodeOutputParameter/NodeOutputs.tsx 0.00% 16 Missing ⚠️
src/frontend/src/CustomNodes/GenericNode/index.tsx 0.00% 11 Missing ⚠️
...FlowPage/components/nodeToolbarComponent/index.tsx 0.00% 10 Missing ⚠️
src/frontend/src/utils/reactflowUtils.ts 0.00% 7 Missing ⚠️
...s/GenericNode/components/NodeOutputfield/index.tsx 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (40.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-1.6.5   #10188   +/-   ##
================================================
  Coverage                 ?   35.68%           
================================================
  Files                    ?     1221           
  Lines                    ?    58147           
  Branches                 ?     5549           
================================================
  Hits                     ?    20747           
  Misses                   ?    37239           
  Partials                 ?      161           
Flag Coverage Δ
frontend 8.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nericNode/components/NodeOutputParameter/index.tsx 0.00% <ø> (ø)
...s/GenericNode/components/NodeOutputfield/index.tsx 0.00% <0.00%> (ø)
src/frontend/src/utils/reactflowUtils.ts 9.87% <0.00%> (ø)
...FlowPage/components/nodeToolbarComponent/index.tsx 0.00% <0.00%> (ø)
src/frontend/src/CustomNodes/GenericNode/index.tsx 0.00% <0.00%> (ø)
...ode/components/NodeOutputParameter/NodeOutputs.tsx 0.00% <0.00%> (ø)
.../components/NodeOutputParameter/nodeOutputUtils.ts 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 9, 2025
@github-actions github-actions bot removed the bug Something isn't working label Oct 9, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 9, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 9, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 9, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 9, 2025
@github-actions github-actions bot added bug Something isn't working and removed bug Something isn't working labels Oct 9, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 9, 2025

@lucaseduoli lucaseduoli merged commit 7c8299f into release-1.6.5 Oct 9, 2025
143 of 146 checks passed
@lucaseduoli lucaseduoli deleted the fix/output_selection branch October 9, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] With 1.6.4, my custom component with multiple output isn't holding the connection to next component

4 participants