📝 Add docstrings to add-lifecycle-events
#10924
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AGUI events to vertices and the graph. Created Decorator to add observability to Langflow workflows. TODO: Unit tests, feature gating to nullify impact in current production code paths. Added unit tests for lifecycle_events. Refraining from using event_manager for now since this capability is goig to stay dormant until APIs are ready for streaming. Added unit tests for before_callback_event and after_callback_event in graph and vertex classes.
Docstrings generation was requested by @dkaushik94. * #10780 (comment) The following files were modified: * `src/lfx/src/lfx/events/observability/lifecycle_events.py` * `src/lfx/src/lfx/graph/graph/base.py` * `src/lfx/src/lfx/graph/vertex/base.py` * `src/lfx/tests/unit/events/observability/test_lifecycle_events.py`
Contributor
Author
|
Important Review skippedCodeRabbit bot authored PR detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
dkaushik94
force-pushed
the
add-lifecycle-events
branch
4 times, most recently
from
5b8031e to
7d1235a
Compare
dkaushik94
force-pushed
the
add-lifecycle-events
branch
2 times, most recently
from
6ab731b to
fb58273
Compare
dkaushik94
force-pushed
the
add-lifecycle-events
branch
4 times, most recently
from
6deba06 to
33e7af1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docstrings generation was requested by @dkaushik94.
The following files were modified:
src/lfx/src/lfx/events/observability/lifecycle_events.pysrc/lfx/src/lfx/graph/graph/base.pysrc/lfx/src/lfx/graph/vertex/base.pysrc/lfx/tests/unit/events/observability/test_lifecycle_events.pyThese files were kept as they were
src/lfx/tests/unit/graph/graph/test_base.pysrc/lfx/tests/unit/graph/vertex/test_vertex_base.pyThese file types are not supported
pyproject.tomlsrc/lfx/pyproject.tomlℹ️ Note