fix: component MCP Tools (SSE): 'Timeout' #5638
Open
+20
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses Python's built-in asyncio.timeout() context manager Properly handles timeout exceptions Maintains the same functionality but with correct async context management
dosubot
bot
added
size:S
azdolinski
changed the title
github-actions
bot
added
bug
+clean up comment
github-actions
bot
added
bug
github-actions
bot
added
bug
Missing args_schema inside cause that tools are generated without input schema and are not able to be properly executed as agent know tool, but dost know what input field tool have. Same problem looks to be in MCP STDIO.
github-actions
bot
added
bug
Line 56: Error: B904 Within an `except` clause, raise exceptions with `raise ... from err` or `raise ... from None` to distinguish them from errors in exception handling TRY003 Avoid specifying long messages outside the exception class EM102 Exception must not use an f-string literal, assign to variable first
github-actions
bot
added
bug
github-actions
bot
added
bug
ogabrielluiz
requested changes
Jan 23, 2025
Comment on lines
42
to
48
| try: | ||
| async with asyncio.timeout(timeout_seconds): | ||
| sse_transport = await self.exit_stack.enter_async_context( | ||
| sse_client(url, headers, timeout_seconds, sse_read_timeout_seconds) | ||
| ) | ||
| self.sse, self.write = sse_transport | ||
| self.session = await self.exit_stack.enter_async_context(ClientSession(self.sse, self.write)) |
There was a problem hiding this comment.
I don't think Python 3.10 has that function.
There was a problem hiding this comment.
I am not quite sure which function you are talking about? Can you be more precise?
There was a problem hiding this comment.
Python 3.10 doesn't have asyncio.timeout(). I think asyncio.wait_for() along with minor modifications to your code would serve the purpose.
There was a problem hiding this comment.
That's why @phact created the custom context manager.
Remove asyncio.timeout() (not valid for Py3.10) and replace it by asyncio.wait_for()
github-actions
bot
added
bug
Move return response.tools inside an else block. This makes it clearer that tools are returned only if the connection is successful, and not if a TimeoutError occurs.
dosubot
bot
added
size:M
github-actions
bot
added
bug
github-actions
bot
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose for resolve: #5637
Tested:
