-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add required=True to necessary components #5679
base: main
Are you sure you want to change the base?
refactor: add required=True to necessary components #5679
Conversation
CodSpeed Performance ReportMerging #5679 will degrade performances by 24.72%Comparing Summary
Benchmarks breakdown
|
@erichare Any suggestions on the Astra Component? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove required is true for URL input (since when used in tool mode it gives error).
General suggestion if the component is being used as a tool i suggest that field need not be set required as true.
@ogabrielluiz what is your suggestion? or should we handle this in component toolkit?
Each component need to be tested in tool mode, when required fields are set
I agree that we should test it but I don't think it should error if the input is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a solid PR overall, but it introduces significant breaking changes. Before merging, we should address a few key points:
• We need to add more comprehensive tests, particularly for scenarios where tool_mode is set to true and required cannot be true at the same time.
• @carlosrcoelho: Can we explore a more refined solution here? Additionally, if feasible, let’s define tasks for specific utilities that can help us thoroughly test these breaking cases.
Let’s revisit this PR after resolving these concerns to ensure a smooth integration.
This pull request adds required=True to essential component fields to improve input validation.