Skip to content

fix: clean up CodeQL alerts#25

Merged
wochinge merged 4 commits into
mainfrom
fix/codeql-alert-cleanup
May 7, 2026
Merged

fix: clean up CodeQL alerts#25
wochinge merged 4 commits into
mainfrom
fix/codeql-alert-cleanup

Conversation

@wochinge
Copy link
Copy Markdown
Collaborator

@wochinge wochinge commented May 7, 2026 •
edited
Loading

Summary

  • fully escape markdown table cells before rendering PR comments
  • exclude scripts/ from CodeQL analysis alongside dist/
  • use a fresh private temp directory for Node SDK installs instead of a predictable shared path
  • rebuild dist for runtime changes

Checks

  • pnpm vitest run tests/comment.test.ts
  • pnpm run lint
  • pnpm run typecheck
  • pnpm vitest run tests/wrappers.test.ts tests/comment.test.ts
  • pnpm run build
  • pre-commit hook ran: build, lint, typecheck, format:check, check:schema

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

@claude review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Experiment Results: bb45a14

Experiment Status Actions
Uppercase (py) ✅ Pass View GitHub Action Run · View in Langfuse
Uppercase (ts) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (node) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (python) ✅ Pass View GitHub Action Run · View in Langfuse
Regression fixture ❌ Regression View GitHub Action Run · View in Langfuse

Details

✅ Uppercase (py) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Uppercase (ts) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (node) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (python) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
❌ Regression fixture (Source)

RegressionError: synthetic regression triggered by e2e fixture

Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Experiment Results: 6ed5b41

Experiment Status Actions
Uppercase (py) ✅ Pass View GitHub Action Run · View in Langfuse
Uppercase (ts) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (node) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (python) ✅ Pass View GitHub Action Run · View in Langfuse
Regression fixture ❌ Regression View GitHub Action Run · View in Langfuse

Details

✅ Uppercase (py) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Uppercase (ts) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (node) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (python) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
❌ Regression fixture (Source)

RegressionError: synthetic regression triggered by e2e fixture

Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000

claude[bot]
claude Bot reviewed May 7, 2026
View reviewed changes
Comment thread src/comment.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Experiment Results: 10f6f38

Experiment Status Actions
Uppercase (py) ✅ Pass View GitHub Action Run · View in Langfuse
Uppercase (ts) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (node) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (python) ✅ Pass View GitHub Action Run · View in Langfuse
Regression fixture ❌ Regression View GitHub Action Run · View in Langfuse

Details

✅ Uppercase (py) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Uppercase (ts) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (node) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (python) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
❌ Regression fixture (Source)

RegressionError: synthetic regression triggered by e2e fixture

Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026 •
edited
Loading

Experiment Results: 9b04341

Experiment Status Actions
Uppercase (py) ✅ Pass View GitHub Action Run · View in Langfuse
Uppercase (ts) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (node) ✅ Pass View GitHub Action Run · View in Langfuse
Mixed dir (python) ✅ Pass View GitHub Action Run · View in Langfuse
Regression fixture ❌ Regression View GitHub Action Run · View in Langfuse

Details

✅ Uppercase (py) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Uppercase (ts) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (node) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
✅ Mixed dir (python) (Source)
Score Value
avg_accuracy 1.000
Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000
❌ Regression fixture (Source)

RegressionError: synthetic regression triggered by e2e fixture

Item results (3)
Item Input Expected Output exact_match
1 langfuse LANGFUSE LANGFUSE 1.000
2 world WORLD WORLD 1.000
3 hello HELLO HELLO 1.000

@wochinge
Copy link
Copy Markdown
Collaborator Author

wochinge commented May 7, 2026

@claude review

@wochinge wochinge merged commit 5fe10b3 into main May 7, 2026
11 checks passed
@wochinge wochinge deleted the fix/codeql-alert-cleanup branch May 7, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wochinge