[fix] fix the bug that modify document name not effective (#10154)

langgenius · Nov 5, 2024 · ac1f93e · ac1f93e
1 parent 0d5c0b4
commit ac1f93e
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/api/services/dataset_service.py b/api/services/dataset_service.py
@@ -986,9 +986,6 @@ def update_document_with_dataset_id(
             raise NotFound("Document not found")
         if document.display_status != "available":
             raise ValueError("Document is not available")
-        # update document name
-        if document_data.get("name"):
-            document.name = document_data["name"]
         # save process rule
         if document_data.get("process_rule"):
             process_rule = document_data["process_rule"]
@@ -1065,6 +1062,10 @@ def update_document_with_dataset_id(
             document.data_source_type = document_data["data_source"]["type"]
             document.data_source_info = json.dumps(data_source_info)
             document.name = file_name
+
+        # update document name
+        if document_data.get("name"):
+            document.name = document_data["name"]
         # update document to be waiting
         document.indexing_status = "waiting"
         document.completed_at = None