refactor: use SDK constants for thread ID attribute #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use AttributeKey.LangWatchThreadId from langwatch SDK instead of hardcoded strings for consistency across JS and Python. Closes #193
drewdrewthis
force-pushed
the
issue193/use-correct-thread-id-attribute-in-jspython-span-collectors-and-backend
branch
from
16dfc5c to
62c51ad
Compare
0xdeafcafe
approved these changes
Dec 12, 2025
Replace hardcoded "langwatch.thread.id" strings with attributes.ATTR_LANGWATCH_THREAD_ID constant.
Update test files to use AttributeKey.LangWatchThreadId (Python) and attributes.ATTR_LANGWATCH_THREAD_ID (JS) instead of hardcoded strings.
Check full attribute key before stripping prefix instead of comparing against stripped constant.
drewdrewthis
deleted the
issue193/use-correct-thread-id-attribute-in-jspython-span-collectors-and-backend
branch
This was referenced Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
AttributeKey.LangWatchThreadIdfrom langwatch SDK in Python instead of hardcoded"langwatch.thread.id"stringattributes.ATTR_LANGWATCH_THREAD_IDfrom langwatch SDK in JS instead of hardcoded stringTest plan
pytest tests/test_judge_span_collector.py)Closes #193