feat: add runId to results and langwatch config options #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewdrewthis
force-pushed
the
issue203/feat-add-programmatic-langwatch-config-to-scenarioconfig-remove-env-var-dependency
branch
from
c375e83 to
12ee25f
Compare
- Add runId field to ScenarioResult for tracking scenario runs - Add RunOptions parameter to run() with langwatch config and batchRunId - Allow programmatic override of env vars for langwatch integration Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
drewdrewthis
force-pushed
the
issue203/feat-add-programmatic-langwatch-config-to-scenarioconfig-remove-env-var-dependency
branch
from
12ee25f to
4fba5ad
Compare
- Resolve batchRunId at call boundary (run.ts) instead of fallback in class - Remove redundant type exports from runner/index.ts - Add guard for uninitialized scenarioRunId in setResult - Add comprehensive tests for runId, batchRunId, and langwatch config Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Adds tests verifying that concurrent scenario runs with different API keys create isolated EventBus instances and don't cross-contaminate events. Also documents the concurrency model in run.ts explaining how each run() call creates its own isolated EventBus, replacing the old mutex-based approach. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
drewdrewthis
requested review from
0xdeafcafe,
Aryansharma28,
llmsommelier and
rogeriochaves
rogeriochaves
approved these changes
Jan 13, 2026
Add logging to trace how batchRunId is resolved in the run() function: - passedBatchRunId: value from options - fallbackBatchRunId: value from getBatchRunId() - resolvedBatchRunId: final value used - optionsKeys: keys present in options object This helps debug cases where the passed batchRunId isn't being used. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…pport Enables consuming the package directly from git with pnpm by adding a prepare script that builds the javascript subdirectory on install. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Skip workspace examples during git dependency install to avoid Node version conflicts with example packages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
npm ignores pnpm workspace config, avoiding engine validation issues with workspace example packages. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes for: langwatch/langwatch#1074