More task management cleanups#93
Merged
Merged
Conversation
bertschinger
force-pushed
the
more_task_management_cleanups
branch
3 times, most recently
from
6d0681a to
e330398
Compare
There are several commands that don't make sense in observe mode, only in manage mode. This makes the manager reject those commands with an error if the admin tries to use them in observe mode.
There are some situations where the manager should not automatically fence a host, but those situations were not checked. This adds checks for all of the situations in which fencing should be illegal.
bertschinger
force-pushed
the
more_task_management_cleanups
branch
from
1433a72 to
e6d9608
Compare
… mode The message type ExitRequested was only used in HA observe mode. By removing it, HA Observe mode is made more consistent with the other operating modes. The HA observe mode logic needs to be modified to correctly handle the case where a node becomes disconnected, now that the ExitRequested message is gone.
bertschinger
force-pushed
the
more_task_management_cleanups
branch
from
e6d9608 to
c86a0b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.