Fix inconsistent logic #145
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors how the Discord instance is accessed throughout the bot's application command logic, introduces a
createmethod for building Discord command objects, and moves theusageproperty to a more appropriate location. The main themes are code consistency, improved command construction, and minor cleanup.Refactoring Discord Instance Access:
$this->discord) with a method call ($this->discord()) throughout theHasApplicationCommandsconcern and related command classes to standardize and encapsulate how the Discord instance is retrieved. [1] [2] [3] [4] [5] [6] [7] [8] [9]Command Construction Improvements:
createmethod to theApplicationCommandclass for building Discord command objects usingCommandBuilder, ensuring consistent construction and serialization of commands.jsonSerialize()instead oftoArray()for compatibility and accuracy in bothHasApplicationCommandsandSlashCommand. [1] [2]Code Organization and Cleanup:
usageproperty from theCommandclass to the more generalAbstractCommandclass, ensuring all commands can define usage information. [1] [2]HasApplicationCommandstrait for clarity and documentation.Dependency Imports:
Discord\Discord,CommandBuilder, andCommandwhere necessary for type safety and clarity. [1] [2]