Make db:seed command prohibitable and mark it destructive
#55231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spawnia
force-pushed
the
db-seed-prohibitable-and-destructive
branch
from
3b48c17 to
523de15
Compare
I think it is generally undesirable and potentially unsafe to execute seeders in production databases. This change does two things: 1. It allows fine-grained control to prohibit `db:seed` from running 2. It includes `db:seed` in `DB::prohibitDestructiveCommands`
spawnia
force-pushed
the
db-seed-prohibitable-and-destructive
branch
from
523de15 to
e7f0a5d
Compare
|
I'm not sure I agree with this change. Seeding is not inherently "destructive", while the other commands are. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it is generally undesirable and potentially unsafe to execute seeders in production databases.
This change does two things:
db:seedfrom runningdb:seedinDB::prohibitDestructiveCommands