Skip to content

[12.x] Table prefix not applied when cloning connections #58288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorotwell merged 6 commits into from
Jan 7, 2026
Merged

[12.x] Table prefix not applied when cloning connections #58288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1ba4391
fix: table prefix not applied when cloning connections
dxnter Jan 5, 2026
758812d
chore: remove model
dxnter Jan 5, 2026
3f9083b
refactor: apply suggestions from code review
dxnter Jan 6, 2026
784b520
refactor: remove `useDefaultPostProcessor()`
dxnter Jan 6, 2026
d0f3c9e
chore: adjust comment
dxnter Jan 6, 2026
5fa8656
formatting
taylorotwell Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/Illuminate/Database/Connection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1716,4 +1716,19 @@ public static function getResolver($driver)
{
return static::$resolvers[$driver] ?? null;
}

/**
* Prepare the instance for cloning.
*
* @return void
*/
public function __clone()
{
// When cloning, re-initialize grammars to reference cloned connection...
$this->useDefaultQueryGrammar();

if (! is_null($this->schemaGrammar)) {
$this->useDefaultSchemaGrammar();
}
}
}
47 changes: 47 additions & 0 deletions tests/Database/DatabaseEloquentIntegrationWithTablePrefixTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,53 @@ public function testBasicModelHydration()
$this->assertCount(1, $models);
}

public function testTablePrefixWithClonedConnection()
{
$originalConnection = $this->connection();
$originalPrefix = $originalConnection->getTablePrefix();

$clonedConnection = clone $originalConnection;
$clonedConnection->setTablePrefix('cloned_');

$this->assertSame($originalPrefix, $originalConnection->getTablePrefix());
$this->assertSame('cloned_', $clonedConnection->getTablePrefix());

$clonedConnection->getSchemaBuilder()->create('test_table', function ($table) {
$table->increments('id');
$table->string('name');
});

$this->assertTrue($clonedConnection->getSchemaBuilder()->hasTable('test_table'));
$query = $clonedConnection->table('test_table')->toSql();
$this->assertStringContainsString('cloned_test_table', $query);

$clonedConnection->getSchemaBuilder()->drop('test_table');
}

public function testQueryGrammarUsesCorrectPrefixAfterCloning()
{
$originalConnection = $this->connection();

$clonedConnection = clone $originalConnection;
$clonedConnection->setTablePrefix('new_prefix_');

$selectSql = $clonedConnection->table('users')->toSql();
$this->assertStringContainsString('new_prefix_users', $selectSql);

$insertSql = $clonedConnection->table('users')->toSql();
$this->assertStringContainsString('new_prefix_users', $insertSql);

$updateSql = $clonedConnection->table('users')->where('id', 1)->toSql();
$this->assertStringContainsString('new_prefix_users', $updateSql);

$deleteSql = $clonedConnection->table('users')->where('id', 1)->toSql();
$this->assertStringContainsString('new_prefix_users', $deleteSql);

$originalSql = $originalConnection->table('users')->toSql();
$this->assertStringContainsString('prefix_users', $originalSql);
$this->assertStringNotContainsString('new_prefix_users', $originalSql);
}

/**
* Helpers...
*/
Expand Down