[12.x] JsonResource@toArray() maps items to array
#58301
Conversation
| is_null($this->resource) => [], | ||
| is_array($this->resource) => $this->resource, | ||
| $this->resource instanceof Collection => $this->resource->map(fn ($val) => $val instanceof JsonResource ? $val->resolve($request) : $val)->toArray(), | ||
| default => $this->resource->toArray($request), |
There was a problem hiding this comment.
Still not positive that this is correct. It's possible that the resource isn't an array, a Collection, or null... in that case, we don't know if there's a toArray() method 🤷
There was a problem hiding this comment.
Wouldn't it make sense to check $this->resource instanceof Arrayable before calling toArray()?
There was a problem hiding this comment.
JsonResource doesn't implement Arrayable anyways. It would have to be a method_exists($this->resource, 'toArray') check. And even then, the toArray() method here differs from Arrayable in its input parameter. 🤷
Also, if it's not an array, null, Arrayable, JsonResource, or Collection, what's the expected behavior? Should it throw an exception? Return an empty array? I have no idea how it's being used by others, so I imagine any choice would cause heartache and strife 😆
2 participants
To close: #58300
For whatever reason, we have tests in our test suite that perform assertions against a
JsonResourceclass. They would calltoArray()on an instance, and then manually calltoArray()onAnonymousResourceCollections returned.It's always uncomfortable to change tests to accommodate a framework change. This change gives developers back that confidence without breaking the new functionality introduced in 12.45.0