-
Notifications
You must be signed in to change notification settings - Fork 11.8k
[12.x] Fix calling toArray() on AnonymousResourceCollection returns an array of resources
#58302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ns an array of resources fixes #58300 Signed-off-by: Mior Muhammad Zaki <[email protected]>
8655a07 to
5677584
Compare
| $this->assertSame(['id' => 10, 'title' => 'Another Test Title', 'custom' => true], $postsAsArray[1]); | ||
| }); | ||
| }); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cosmastech this should cover your current use case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against our codebase and appears to be working. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also fixes issues in our codebase. Thanks @crynobone
Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
Thanks for the speedy fix! This PR seems to address some of the issues we're running into as well. 🙂 |
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
fixes #58300
fixes #58297
fixes #58307