[12.x] Add tests for JsonSchemaTypeFactory #58306
Closed
+255
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We already have pretty good tests for this components. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for the
JsonSchemaTypeFactoryclass.New Tests:
Factory instance methods for all types (object, array, string, integer, number, boolean)
Object creation with properties array and closure
Static method calls via JsonSchema::*
Fluent API chaining with multiple constraints
Deeply nested object schemas
Array types with object items
These tests ensure the factory properly creates type instances and that the fluent API works correctly for complex schema definitions.