Replacing left/right classes with start/end to support RTL #1392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you link to some resources where Tailwind recommends these as best practices? |
|
While Tailwind CSS doesn't explicitly mention CSS logical properties as the best practice, they are widely recognized as best practices in web development for making it easier to support RTL languages ( Arabic, Farsi, Hebrew .. etc ) see sources below. This change will make Jetstream RTL ready, Only add Thank you for your consideration. Sincerely, |
This was referenced Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request aims to enhance the internationalization (I18N) and readability of the project by replacing the usage of
leftandrightclasses withstartandendclasses. By making this change, we will ensure better support for right-to-left (RTL) languages and align the codebase with Tailwind CSS's conventions for improved semantic clarity.Details:
Changes Made:
leftclasses withstartclasses.rightclasses withendclasses.mlandplclasses withmsandpsclasses.mrandprclasses withmeandpeclasses.text-leftclasses withtext-startclasses.text-rightclasses withtext-endclasses.$alignmentClassesin dropdown component to handle ltr and rtl correctly.Testing:
Please review these changes, and I look forward to your feedback and any further guidance on the proposed updates.
Thank you for considering this pull request.
Sincerely,
Abdullah