Fix: Duplicate chat messages #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad user chat message from db & only send new prompt when authenticated
…as/larachat into hotfix/duplicate-chat-messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Previously, the
stream()controller method relied on the client to send the full conversation history back to the server for both authenticated and guest users. On each authenticated request (Chat exists), the server would re-save any messages without an id. With this design if a user had an existing chat and refreshed the page, the client re-sent all messages from state. The backend then persisted those messages again, resulting in duplicated messages being stored in the database.This PR makes the database the source of truth for chat history of authenticated users, while still allowing the full message context to be sent for guests/anonymous chats.
Demo
Before
larachat_bug_pr.mp4
After
larachat_fixed.mp4