Make IP to bind the server to configurable via env (#607)

laravel · Nov 2, 2022 · 24ab7f9 · 24ab7f9
1 parent 8caf947
commit 24ab7f9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/src/Commands/Concerns/InteractsWithServers.php b/src/Commands/Concerns/InteractsWithServers.php
@@ -120,6 +120,16 @@ protected function getServerOutput($server)
         ], fn () => $server->clearOutput()->clearErrorOutput());
     }
 
+    /**
+     * Get the Octane HTTP server host IP to bind on.
+     *
+     * @return string
+     */
+    protected function getHost()
+    {
+        return $this->option('host') ?? config('octane.host') ?? $_ENV['OCTANE_HOST'] ?? '127.0.0.1';
+    }
+
     /**
      * Get the Octane HTTP server port.
      *

diff --git a/src/Commands/StartCommand.php b/src/Commands/StartCommand.php
@@ -56,7 +56,7 @@ public function handle()
     protected function startSwooleServer()
     {
         return $this->call('octane:swoole', [
-            '--host' => $this->option('host'),
+            '--host' => $this->getHost(),
             '--port' => $this->getPort(),
             '--workers' => $this->option('workers'),
             '--task-workers' => $this->option('task-workers'),
@@ -74,7 +74,7 @@ protected function startSwooleServer()
     protected function startRoadRunnerServer()
     {
         return $this->call('octane:roadrunner', [
-            '--host' => $this->option('host'),
+            '--host' => $this->getHost(),
             '--port' => $this->getPort(),
             '--rpc-port' => $this->option('rpc-port'),
             '--workers' => $this->option('workers'),

diff --git a/src/Commands/StartRoadRunnerCommand.php b/src/Commands/StartRoadRunnerCommand.php
@@ -114,7 +114,7 @@ protected function writeServerStateFile(
     ) {
         $serverStateFile->writeState([
             'appName' => config('app.name', 'Laravel'),
-            'host' => $this->option('host'),
+            'host' => $this->getHost(),
             'port' => $this->getPort(),
             'rpcPort' => $this->rpcPort(),
             'workers' => $this->workerCount(),

diff --git a/src/Commands/StartSwooleCommand.php b/src/Commands/StartSwooleCommand.php
@@ -104,7 +104,7 @@ protected function writeServerStateFile(
     ) {
         $serverStateFile->writeState([
             'appName' => config('app.name', 'Laravel'),
-            'host' => $this->option('host'),
+            'host' => $this->getHost(),
             'port' => $this->getPort(),
             'workers' => $this->workerCount($extension),
             'taskWorkers' => $this->taskWorkerCount($extension),