Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables the RPC functionality of supervisord, making you able to control the processes that are managed by supervisord inside the application container. This pull request will also add a sub command to the sail shell script to interact with supervisorctl directly instead of going through a shell (
./vendor/bin/sail shell
or the likes) .Example usage:
./vendor/bin/sail supervisorctl
./vendor/bin/sail supervisorctl restart php
./vendor/bin/sail supervisorctl --help
This change doesn't expose any additional ports as a UNIX socket is used. That socket is owned by the sail user so the security implications should be minimal, if any. The only noticeable change for the end user would be the new command in the sail shell script.
This will add value for those debugging the internals of the sail container and especially to those who have published the Dockerfiles and added their own programs to supervisord. It's also a possible timesave to have direct access towards the supervisorctl binary, and that it works out of the box.
Fixes #584