Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable supervisorctl usage #618

Closed
wants to merge 2 commits into from
Closed

Enable supervisorctl usage #618

wants to merge 2 commits into from

Conversation

alu-
Copy link

@alu- alu- commented Sep 13, 2023

This pull request enables the RPC functionality of supervisord, making you able to control the processes that are managed by supervisord inside the application container. This pull request will also add a sub command to the sail shell script to interact with supervisorctl directly instead of going through a shell (./vendor/bin/sail shell or the likes) .

Example usage:
./vendor/bin/sail supervisorctl
./vendor/bin/sail supervisorctl restart php
./vendor/bin/sail supervisorctl --help

This change doesn't expose any additional ports as a UNIX socket is used. That socket is owned by the sail user so the security implications should be minimal, if any. The only noticeable change for the end user would be the new command in the sail shell script.

This will add value for those debugging the internals of the sail container and especially to those who have published the Dockerfiles and added their own programs to supervisord. It's also a possible timesave to have direct access towards the supervisorctl binary, and that it works out of the box.

Fixes #584

@alu- alu- marked this pull request as ready for review September 13, 2023 15:18
@taylorotwell
Copy link
Member

You can publish the Docker files and add this if you wish.

@alu-
Copy link
Author

alu- commented Sep 13, 2023

You can publish the Docker files and add this if you wish.

Not the sail command, but otherwise correct. Thank you for taking the time reviewing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supervisor socket file missing
2 participants