Feature: add support for phpmyadmin #700
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request proposes the addition of phpMyAdmin to Laravel Sail.
To achieve this,
stubs/phpmyadmin.stub
has been created which contains a standard implementation that will work out of the box assuming mysql has been selected.Additionally,
InteractsWithDockerComposeServices
has been modified to addphpmyadmin
to the protected$services
array.Currently, at work, we add phpMyAdmin manually to every project using Laravel Sail - and have long wondered if it was something that belongs within the installer. The benefit of this to end users is essentially in time; by having it installed out of the box, we remove the need to revisit old projects to find an old
pma
entry.The obvious critique is that a new user may not realise that phpMyAdmin won't work with, say, MariaDB out of the box. I suspect checking for this and modifying the stub as required wouldn't be too complicated, but wanted to at least check in here before I go to that length!