Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add support for phpmyadmin #700

Closed

Conversation

tommitchelmore
Copy link

This pull request proposes the addition of phpMyAdmin to Laravel Sail.

To achieve this, stubs/phpmyadmin.stub has been created which contains a standard implementation that will work out of the box assuming mysql has been selected.

Additionally, InteractsWithDockerComposeServices has been modified to add phpmyadmin to the protected $services array.

Currently, at work, we add phpMyAdmin manually to every project using Laravel Sail - and have long wondered if it was something that belongs within the installer. The benefit of this to end users is essentially in time; by having it installed out of the box, we remove the need to revisit old projects to find an old pma entry.

The obvious critique is that a new user may not realise that phpMyAdmin won't work with, say, MariaDB out of the box. I suspect checking for this and modifying the stub as required wouldn't be too complicated, but wanted to at least check in here before I go to that length!

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants