-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/delayed delivery #24
base: main
Are you sure you want to change the base?
Conversation
The code for symbol change and stock merger does not actually change the open positions in the fifo, |
Seems the option assignment was recorded 12 days earlier (09/17/2021) and probably the adjustment |
I've merged in the first three patches into my repository and also added a link to The symbol change and stock merger still need more work to adjust the currently open positions Thanks a lot for the patches, Florian La Roche |
b92d2f5
to
c4be7bd
Compare
c4be7bd
to
27427a5
Compare
Yes, that time was very chaotic. It was a pump and dump and short interest was very high. |
I can see that now. I have heavily reduced this Merge Request because I can see that it's not reviewable otherwise. And half-features don't help. I can continue to implement some unimplemented features, but I have real problems implementing the stock merge / reverse split / symbol change. Those are all untaxable events, but I don't understand how I can mark them as 'tax_free'. I'll open a separate pull request to explain the problem if I can't make any progress on my own. |
tax_free is only used as marker for USD changes. Everything else just has "PnL" computed and is grouped into best regards, Florian La Roche |
Yes! That helps, thanks! |
Depends on #23
I had trouble with this line:
Error message was
It's running now with the attached test data. I'm not sure if that is a taxable event or not?
gree.csv