improve the implementation for 12. missing validation of parameters

larry0x · Aug 30, 2023 · d1b955b · d1b955b
1 parent 88f3fe5
commit d1b955b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/x/abstractaccount/types/params.go b/x/abstractaccount/types/params.go
@@ -34,17 +34,13 @@ func (p *Params) Validate() error {
 	}
 
 	// allowed list must contain non-zero, unique, and sorted code IDs
-	prev := uint64(0)
+	prevCodeID := uint64(0)
 	for _, codeID := range p.AllowedCodeIDs {
-		if codeID == 0 {
+		if prevCodeID >= codeID {
 			return ErrMalformedAllowList
 		}
 
-		if prev >= codeID {
-			return ErrMalformedAllowList
-		}
-
-		prev = codeID
+		prevCodeID = codeID
 	}
 
 	return nil

diff --git a/x/abstractaccount/types/params_test.go b/x/abstractaccount/types/params_test.go
@@ -43,7 +43,7 @@ func TestValidateParams(t *testing.T) {
 			desc: "allow list contains zero code ID",
 			params: &types.Params{
 				AllowAllCodeIDs: false,
-				AllowedCodeIDs:  []uint64{1, 0, 3},
+				AllowedCodeIDs:  []uint64{0, 1, 2},
 				MaxGasBefore:    types.DefaultMaxGas,
 				MaxGasAfter:     types.DefaultMaxGas,
 			},