Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make crashdumpbrowser server work with newer PHP versions and with current client #24

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

IBwWG
Copy link

@IBwWG IBwWG commented Jun 13, 2016

Fixes #20 and #25 , although #25 was just caused by my not-quite-ready PR...

@IBwWG IBwWG changed the title Make work with newer PHP versions Make crashdumpbrowser server work with newer PHP versions and with current client Jun 13, 2016
I didn't realize what I had done here.  Package makes much more sense, otherwise each crash is its own "project" in the browser.
@IBwWG
Copy link
Author

IBwWG commented Jun 13, 2016

Hmm, not sure if my fix is bad, or it's another issue, but the grid only returns one row, when it should return more. Also, it seems to have the project mismatched with the rest of the data (test project vs my actual submitted ones from my project.)

If I go to grid.php without any parameters, it lists everything (and nothing is mis-matched), but with the empty parameters as sent by Firefox, I only get the one row (if I set the project to "all" or to the one that most of the line's data comes from. Even though the line says "test", setting project to "test" makes nothing show.)

Although, it seems to be related to what happens to be selected in the three selection boxes (type/file/function)...if I manually click the top then shift-click the bottom in each of those (sadly, ctrl+A doesn't work; also shift-reload doesn't clear my selections) and then click Apply Filters, I get more of the data (4/7 rows; I guess the 4 unique spots), but every row still says (as the server returned in this case, but not grid.php plain vanilla) Test Project.

OK, a couple shift-reloads in a row worked....now the data appears correctly in the table.

I didn't think this was related to this PR; however, the method of converting values into references may be flawed...

Although, it doesn't seem to be: if I compare $refs to $params they look the same:

array(6) { [0]=> &string(5) "iiiii" [1]=> &int(1) [2]=> &string(1) "0" [3]=> &string(1) "5" [4]=> &int(0) [5]=> &int(50) }
array(6) { [0]=> &string(5) "iiiii" [1]=> &int(1) [2]=> &string(1) "0" [3]=> &string(1) "5" [4]=> &int(0) [5]=> &int(50) } 

So, maybe it's a combination of a client-side flaw (i.e. probably it used to work, and then browser behaviour changed) and how the PHP code handles the difference.

Keep taking any later stack trace lines, since stack traces are at the end of crashdumper output anyway
"can be used in any version. Haxelib will then always try to use the latest version." → not what I need just now; forcing with "haxelib set" doesn't override this dependency...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants