-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redo what
tab completion feature
#38
Conversation
Everything should be good. There are a few edge cases, like |
Looks like all the failing tests are typos in files I didn't change... |
a3a2697
to
3267e79
Compare
Umm, any idea what happened here? In any case, I cleaned up my commit history, so it should be ready for a merge if you think it's good. |
Try using |
f547ba4
to
7f373b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase -i -r
and drop of commits not authored in this PR seems to have done the trick!
7f373b9
to
73cf3c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some cleanup needs to happen in env/redo_completion.sh. There is a lot of unnecessary white space and commented out code that hinders readability. The actual code looks good though.
This helps with tab completion programs to differentiate between directories and files. This change helps in preparation for the merge of lasp#38.
5184e0d
to
643048f
Compare
Now it should be done, I took your suggestions and made a few other changes. (but the of course tests are failing for some reason...) |
643048f
to
a81f0fe
Compare
It looks like they're all permissions errors... Does this have to do with changing the Dockerfile to end with |
Create the redo command
redo what_predefined
, which displays the commands listed inredo what
which will always be listed regardless of the subdirectory of the project you're in.