Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo what tab completion feature #38

Merged
merged 5 commits into from
May 31, 2024
Merged

Conversation

MyApaulogies
Copy link
Collaborator

Create the redo command redo what_predefined, which displays the commands listed in redo what which will always be listed regardless of the subdirectory of the project you're in.

@dinkelk dinkelk changed the title Create redo what_predefined redo what tab completion feature May 21, 2024
@MyApaulogies
Copy link
Collaborator Author

Everything should be good. There are a few edge cases, like cding into a build directory still brings up completions, and trying to complete redo ../adamant while in ~/adamant doesn't work, and also it's a bit slower than it could be (rewrite it in Rust?) It seems usable now though, if someone wants to test it out.

@MyApaulogies
Copy link
Collaborator Author

Looks like all the failing tests are typos in files I didn't change...

@MyApaulogies
Copy link
Collaborator Author

MyApaulogies commented May 30, 2024

dinkelk and others added 18 commits May 30, 2024 23:26

Umm, any idea what happened here? In any case, I cleaned up my commit history, so it should be ready for a merge if you think it's good.

@Jbsco
Copy link
Collaborator

Jbsco commented May 31, 2024

Try using rebase -i -r HEAD~# to drop commits not authored in this PR, then rebasing on main, then again with --committer-date-is-author-date to restore inline commit dates. There may be other ways to do this, but should work.

@Jbsco Jbsco force-pushed the bash-completions branch 2 times, most recently from f547ba4 to 7f373b9 Compare May 31, 2024 16:25
Copy link
Collaborator

@Jbsco Jbsco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase -i -r and drop of commits not authored in this PR seems to have done the trick!

Copy link
Collaborator

@dinkelk dinkelk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some cleanup needs to happen in env/redo_completion.sh. There is a lot of unnecessary white space and commented out code that hinders readability. The actual code looks good though.

env/activate Show resolved Hide resolved
default.do Show resolved Hide resolved
redo/rules/build_what_predefined.py Outdated Show resolved Hide resolved
redo/rules/build_what_predefined.py Outdated Show resolved Hide resolved
env/redo_completion.sh Outdated Show resolved Hide resolved
env/redo_completion.sh Show resolved Hide resolved
dinkelk added a commit to dinkelk/adamant that referenced this pull request May 31, 2024
This helps with tab completion programs to differentiate between
directories and files. This change helps in preparation for the merge
of lasp#38.
@MyApaulogies MyApaulogies force-pushed the bash-completions branch 4 times, most recently from 5184e0d to 643048f Compare May 31, 2024 21:31
@MyApaulogies
Copy link
Collaborator Author

Now it should be done, I took your suggestions and made a few other changes. (but the of course tests are failing for some reason...)

@MyApaulogies
Copy link
Collaborator Author

It looks like they're all permissions errors... Does this have to do with changing the Dockerfile to end with USER user instead of USER root?

@dinkelk dinkelk merged commit 6d49a94 into lasp:main May 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants