Fix for linking to unbuilt C/C++ objects #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinkelk
added a commit
to dinkelk/adamant_example
that referenced
this pull request
Oct 17, 2024
This enables the fix in lasp/adamant#85 for this repository.
Linking to C/C++ would fail when only a portion of the C/C++ source files in a directory are dependencies of the currently compiling binary. Only some of the files would be compiled into objects, but GPRBuild (by default) tries to link to all C/C++ objects found in a directory in the Source_Dirs. To work around this, at link time, we now pass a list of files to exclude from the build, which includes C/C++ files that exist in the Source_Dirs, but are not dependencies of the currently compiling binary.
dinkelk
added a commit
to dinkelk/adamant
that referenced
this pull request
Oct 17, 2024
dinkelk
added a commit
to dinkelk/adamant
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking to C/C++ would fail when only a portion of the C/C++ source files in a directory are dependencies of the currently compiling binary. Only some of the files would be compiled into objects, but GPRBuild (by default) tries to link to all C/C++ objects found in a directory in the Source_Dirs. To work around this, at link time, we now pass a list of files to exclude from the build, which includes C/C++ files that exist in the Source_Dirs, but are not dependencies of the currently compiling binary.