Docker Compose Conversion #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jbsco
force-pushed
the
docker-compose
branch
3 times, most recently
from
ef6680f
to
df848ca
Compare
|
This is functional on Linux, but testing on Windows using |
Jbsco
force-pushed
the
docker-compose
branch
2 times, most recently
from
158a6e7
to
93364c8
Compare
This is an issue with pathing in the |
Jbsco
force-pushed
the
docker-compose
branch
7 times, most recently
from
243ad9f
to
92655ed
Compare
dinkelk
reviewed
Jun 20, 2024
dinkelk
requested changes
Jun 20, 2024
Jbsco
force-pushed
the
docker-compose
branch
3 times, most recently
from
6756846
to
24bc83c
Compare
dinkelk
approved these changes
Jun 24, 2024
Convert Docker run script to Docker Compose (`docker compose up -d`) Make `adamant_env.sh` executable Add all usage args to `adamant_env.sh` output when run with no args Reword `adamant_env.sh` output to be more approachable to users Change `stop` arg to stop the container rather than remove Remove scripts replaced by `adamant_env.sh` Retain and use `docker_config.sh` for user configuration Add Docker Compose network mode for changes in lasp#24 Apply `compose.yaml` fixes for Windows Rename compose.yaml->compose.yml Update compose.yml to use docker_config.sh vars Improve `adamant_env.sh` input handling Convert remaining `docker` commands to `docker-compose` Fix script `build` arg to function with `docker-compose` Apply fix to to enable `build` and `push`
Apply fixes to `docker/README.md`
Apply fixes to Linux README.md
Expand BASH readlink to apply project name in script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should follow #24. These changes convert the current Docker scripts into a unified Docker Compose script which manages Docker container operations with arguments such as
start,stop,login,push,build, andremove. The Docker configuration is contained within thecompose.yamlfile and is provided as an argument to thedocker-composecommand contained within the unified script.