-
Notifications
You must be signed in to change notification settings - Fork 783
Fixed server deployment docs for MCP Agent Cloud #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added deployment patterns and examples for FastMCP and MCPApp. Updated configuration details and clarified usage scenarios.
WalkthroughReplaces the prior FastMCP-focused example with a dual-pattern "Choosing your deployment pattern" section describing FastMCP and MCPApp, updates code samples/imports to the MCPApp flow, adds optional resource endpoint and docstrings, and revises configuration, upgrade, and deployment guidance for both patterns. (50 words) Changes
Sequence Diagram(s)(omitted — changes are documentation-only and do not alter runtime control flow) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📚 Learning: 2025-08-28T15:07:10.015ZApplied to files:
📚 Learning: 2025-07-22T18:59:49.368ZApplied to files:
🔇 Additional comments (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| from mcp_agent.app import MCPApp | ||
|
|
||
| # Configuration path | ||
| CONFIG_PATH = (Path(__file__).parent / "mcp_agent.config.yaml").resolve() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, not needed!
| `mcp_agent.secrets.yaml` remains optional unless your server calls external APIs. | ||
|
|
||
| ## MCPApp-only example (no workflows) | ||
| ## Deploying an MCPApp as a server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't both options an MCPApp?
| app = MCPApp( | ||
| name="markdown-tools", | ||
| description="Text processing tools", | ||
| settings=str(CONFIG_PATH), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
| ``` | ||
|
|
||
| Because there are no workflows, the app behaves like a standard MCP server but you can add Temporal-backed workflows later without changing the deployment process. | ||
| This app behaves like a standard MCP server but you can add Temporal-backed workflows later (using `@app.async_tool` and `@app.workflow`) without changing the deployment process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a true statement?
Updated the description and clarified deployment process for cloud applications after Andrew's review.
Added deployment patterns and examples for FastMCP and MCPApp. Updated configuration details and clarified usage scenarios.
Summary by CodeRabbit