-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Mobile: Improve note screen tests and fix CI warning #11126
Merged
laurent22
merged 2 commits into
laurent22:dev
from
personalizedrefrigerator:pr/mobile/improve-note-screen-tests
Sep 27, 2024
Merged
Chore: Mobile: Improve note screen tests and fix CI warning #11126
laurent22
merged 2 commits into
laurent22:dev
from
personalizedrefrigerator:pr/mobile/improve-note-screen-tests
Sep 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves the mobile note screen tests. In particular, it: - Tests repeatedly updating the note title, verifying that the note is indeed saved. - Tests updating the note body: - Adding chunks and checking that they save before the component unmounts. - FAILING TEST: Adding text to the note editor then rapidly unmounting the component.
This pull request seems to fix a large number of warnings observed recently in CI: Related logs from a recent CI run
|
personalizedrefrigerator
changed the title
Chore: Mobile: Improve note screen tests
Chore: Mobile: Improve note screen tests and fix CI warning
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request improves the mobile note screen tests.
Goal: Simplify writing tests that 1) modify the content of the mobile note editor, then 2) check for a change based on that modification (e.g. note save).
In particular, it:
Note
#11127 can be observed while running the new tests.