Skip to content

🧹 [Code Health] Remove unused Iterable import in friction_parse.py and enforce ruff on CI/Pre-commit#2124

Open
laurigates wants to merge 1 commit into
mainfrom
🧹-code-health-improvement-friction-parse-10218288211361800122

Hidden character warning

The head ref may contain hidden characters: "\ud83e\uddf9-code-health-improvement-friction-parse-10218288211361800122"
Open

🧹 [Code Health] Remove unused Iterable import in friction_parse.py and enforce ruff on CI/Pre-commit#2124
laurigates wants to merge 1 commit into
mainfrom
🧹-code-health-improvement-friction-parse-10218288211361800122

Conversation

@laurigates

Copy link
Copy Markdown
Owner

🎯 What: Removed unused typing.Iterable import from feedback-plugin/scripts/friction_parse.py. I also applied ruff format and ruff check --fix over the same file to keep standard code style. Additionally, I added ruff checks to both the pre-commit configuration and the GitHub actions CI pipeline to ensure better code health checking in the future.
💡 Why: Unused imports clutter the codebase and can occasionally lead to confusion. Fixing format standardizes the style. Running these checks on CI ensures that code quality doesn't drift.
Verification: Verified ruff check passes after changes. Verified the feedback-plugin/ pytest suite completely passes (14 tests passed).
Result: A cleaner friction_parse.py script without dead code logic and standardized format across the codebase enforced at commit time via .pre-commit-config.yaml and .github/workflows/plugin-pr-checks.yml.


PR created automatically by Jules for task 10218288211361800122 started by @laurigates

…parse.py and enforce via CI

Co-authored-by: laurigates <13014001+laurigates@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant