fix(just): bind empty assoc array; add plugins-reconcile-keys - #343
Merged
Conversation
Two changes to the canonical plugins recipes.
1. `_plugins-annotate` aborted with "seen: unbound variable" for any repo
with zero laurigates plugins. Under `set -u`, bash 5.3 treats a
`declare -A seen` that is never assigned as UNBOUND, so `${#seen[@]}`
fails — and it failed on exactly the repos an audit most needs to
report (OLMap, kicad-mcp: a claude.yml present with nothing enabled).
`declare -A seen=()` binds it.
2. New `plugins-reconcile-keys` — the safe half of `plugins-sync-repo`,
for unattended use. It reconciles the key SET of an exhaustive pin
against canonical (adds omitted canonical plugins, drops pins for
plugins gone from the marketplace) while leaving each repo's own
enable/disable VALUES alone.
The distinction is load-bearing. A missing key is a real functional
bug: enabledPlugins is a whole-map replacement, so a plugin omitted
from an exhaustive pin is silently disabled in web/remote sessions.
A differing value is not a bug — it is stack-specific and drifts in
both directions on purpose (`infrastructure` keeps terraform-plugin
and kubernetes-plugin ON where canonical has them OFF). Blanket
`plugins-sync-repo` would disable exactly the plugins a repo needs,
so it stays a deliberate, interactive operation.
Refuses to run if the marketplace fetch fails, rather than treating
an empty response as "every plugin was removed".
Consumed by the new weekly ~/repos/.routines/plugins-audit.sh sweep.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012zrh72rhT9VtdDYKnjRyVh
Contributor
|
| Status | Count |
|---|---|
| 🔍 Total | 170 |
| ✅ Successful | 160 |
| ⏳ Timeouts | 0 |
| 🔀 Redirected | 0 |
| 👻 Excluded | 9 |
| ❓ Unknown | 0 |
| 🚫 Errors | 1 |
Errors per input
Errors in exact_dot_claude/docs/prds/daily-catchup.PRD.md
- [404] https://docs.anthropic.com/claude-code/commands | Failed: Network error: Not Found
Full Github Actions output
Please fix the broken links before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes to the canonical Claude-plugins recipes, both needed by the new weekly
plugins-auditroutine in~/repos/.routines/.1.
_plugins-annotatecrashed on zero-plugin reposUnder
set -u, bash 5.3 treats adeclare -A seenthat is never assigned as unbound, so${#seen[@]}aborts the recipe. It fired on exactly the repos an audit most needs to report —OLMapandkicad-mcp, which have aclaude.ymlworkflow but zero plugins enabled.declare -A seen=()binds it.Reproduce:
2. New
plugins-reconcile-keys— the unattended-safe half ofplugins-sync-repoReconciles the key set of an exhaustive pin against canonical while leaving each repo's own enable/disable values alone:
The distinction is load-bearing, and is why the existing
plugins-sync-repomust stay a deliberate interactive operation:enabledPluginsis a whole-map replacement, so a plugin omitted from an exhaustive pin is silently disabled in web/remote sessions.infrastructurekeepsterraform-pluginandkubernetes-pluginon where canonical has them off.Measured across the four exhaustive-pinned repos before writing this:
Blanket-syncing those would disable exactly the plugins each repo needs.
Also refuses to run when the marketplace fetch fails, rather than treating an empty response as "every plugin was removed" — which would strip pins portfolio-wide.
Verification
Re-running is a no-op ("Key set already canonical"). The
infrastructuretest write was reverted; the real change will land via the routine's PR.🤖 Generated with Claude Code
https://claude.ai/code/session_012zrh72rhT9VtdDYKnjRyVh