Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimizer Refactor Part 2: Add prometheus metrics for refactor optimizer #1802

Open
wants to merge 10 commits into
base: CNS-1008-score-store-refactor
Choose a base branch
from

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

Note, do not merge this to main. The refactor branches will be used to create a benchmark version for testing.

Added prometheus metrics for the refactored optimizer


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@oren-lava oren-lava self-assigned this Nov 26, 2024
@oren-lava oren-lava changed the title feat: Optimizer Refactor Part 2: Add prometheus metrics for refactor optimizer refactor: Optimizer Refactor Part 2: Add prometheus metrics for refactor optimizer Nov 26, 2024
@pull-request-size pull-request-size bot added size/XL and removed size/L labels Dec 2, 2024
@pull-request-size pull-request-size bot added size/L and removed size/XL labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant