Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PRT - adding stickiness header #1942

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

Yaroms
Copy link
Collaborator

@Yaroms Yaroms commented Feb 4, 2025

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Feb 4, 2025

Test Results

2 519 tests  ±0   2 518 ✅ ±0   27m 44s ⏱️ + 2m 8s
  124 suites ±0       1 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 7177244. ± Comparison against base commit 6088bbb.

♻️ This comment has been updated with latest results.

@Yaroms Yaroms marked this pull request as ready for review February 5, 2025 09:50
@Yaroms Yaroms changed the title adding header feat: adding stickiness header Feb 5, 2025
@pull-request-size pull-request-size bot added size/L and removed size/XS labels Feb 5, 2025
@ranlavanet ranlavanet changed the title feat: adding stickiness header feat: PRT - adding stickiness header Feb 12, 2025
}
}
if !providerValid {
delete(csm.stickySessions, stickiness)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we break stickiness we want to alert the user somehow? maybe returning a header of stickiness kept / broken ?

Also will be easier to debug if users complain.

you can do this by adding a method to csm to return sticky session supposed provider and cross validating it with the provider address that returned the request in rpcconsumer_server.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants