Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reported provider event non-deterministic #1972

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

oren-lava
Copy link
Collaborator

Description

Closes: #XXXX

The timestamp trait was non deterministic. Fixed to make it use UTC and constant format.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • read the contribution guide
  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the main branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Copy link

github-actions bot commented Feb 24, 2025

Test Results

2 519 tests  ±0   2 518 ✅ ±0   27m 26s ⏱️ + 1m 5s
  124 suites ±0       1 💤 ±0 
    7 files   ±0       0 ❌ ±0 

Results for commit 28a9618. ± Comparison against base commit 6a9ec08.

♻️ This comment has been updated with latest results.

ranlavanet
ranlavanet previously approved these changes Feb 24, 2025
@Yaroms Yaroms merged commit 8a2d890 into main Feb 25, 2025
29 checks passed
@Yaroms Yaroms deleted the fix-non-deterministic-reported-provider-event branch February 25, 2025 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants