-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add table component #6231
base: master
Are you sure you want to change the base?
add table component #6231
Conversation
Signed-off-by: eyeaadil <[email protected]>
🚀 Preview for commit ddc452a at: https://67aa6218f0fec017eb69909b--layer5.netlify.app |
Good work @eyeaadil, but check why the Try building it locally and re-push with changes, As it's hard to review without the preview site. |
Okay I will fix this issue, currently I am busy in semester exams. |
import { navigate } from "gatsby"; | ||
import { useLocation } from "@reach/router"; | ||
import { | ||
Table, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't use anything from ui, use Responsivetable
component from sistent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see examples in meshery repo how tables being used...
@eyeaadil adding it as an agenda item to the meeting minutes. |
🚀 Preview for commit 17f7508 at: https://67b305837be2aa85b0c2f55b--layer5.netlify.app |
@Vidit-Kushwaha I will fix the issue , currently my mid sem exams is start , so I am busy in that. |
Description
This PR fixes #5962


After
Notes for Reviewers
Signed commits