Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add table component #6231

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eyeaadil
Copy link
Contributor

@eyeaadil eyeaadil commented Feb 10, 2025

Description

This PR fixes #5962
After
image
image

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: eyeaadil <[email protected]>
@l5io
Copy link
Contributor

l5io commented Feb 10, 2025

🚀 Preview for commit ddc452a at: https://67aa6218f0fec017eb69909b--layer5.netlify.app

@mdkaifansari04
Copy link
Contributor

Good work @eyeaadil, but check why the lighthousecli is failing maybe there is some issue with build or git signing.

Try building it locally and re-push with changes, As it's hard to review without the preview site.

@eyeaadil
Copy link
Contributor Author

Good work @eyeaadil, but check why the lighthousecli is failing maybe there is some issue with build or git signing.

Try building it locally and re-push with changes, As it's hard to review without the preview site.

Okay I will fix this issue, currently I am busy in semester exams.

import { navigate } from "gatsby";
import { useLocation } from "@reach/router";
import {
Table,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use anything from ui, use Responsivetable component from sistent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see examples in meshery repo how tables being used...

@vishalvivekm
Copy link
Contributor

vishalvivekm commented Feb 17, 2025

@eyeaadil
Thank you for your contribution!
Let's discuss this during the website call on today at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

@l5io
Copy link
Contributor

l5io commented Feb 17, 2025

🚀 Preview for commit 17f7508 at: https://67b305837be2aa85b0c2f55b--layer5.netlify.app

@Vidit-Kushwaha
Copy link
Contributor

@eyeaadil You have to add a components source to the components/index.js; you can take reference here.

@eyeaadil
Copy link
Contributor Author

@Vidit-Kushwaha I will fix the issue , currently my mid sem exams is start , so I am busy in that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Sistent] Add Table component to the sistent components page
6 participants