-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js #6239
base: master
Are you sure you want to change the base?
changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js #6239
Conversation
Signed-off-by: Fritozz-105 <[email protected]>
🚀 Preview for commit aca22aa at: https://67b18e68eb0cffee127bac5b--layer5.netlify.app |
@Fritozz-105 |
Thank you so much for working on this!!! ![]() Additionally, @vishalvivekm suggests having coloured logos in light theme, could you ensure that's taken care of? |
@SAHU-01 |
Signed-off-by: Fritozz-105 <[email protected]>
🚀 Preview for commit 1ae8f1d at: https://67b657cdcb08e2ccc8624c5c--layer5.netlify.app |
Signed-off-by: Fritozz-105 <[email protected]>
🚀 Preview for commit 47d25d2 at: https://67b667e8929937f17eb6bd97--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the background color of black to be a little strange. What's your thought, @vishalvivekm?
Description
This PR fixes #5286
Notes for Reviewers
Edited the styling files and changed the static color to blackToWhite, whiteToBlack, etc. so the color changes when toggling light/dark mode. I added a filter to the themeStyles.js because it said it wasn't advised to use a conditional for color changes.
Signed commits