Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed static colors to dynamic theme colors in Scenario.Card.style.js and LabsWrapper.style.js #6239

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Fritozz-105
Copy link

@Fritozz-105 Fritozz-105 commented Feb 16, 2025

Description

This PR fixes #5286

Notes for Reviewers
Edited the styling files and changed the static color to blackToWhite, whiteToBlack, etc. so the color changes when toggling light/dark mode. I added a filter to the themeStyles.js because it said it wasn't advised to use a conditional for color changes.

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Feb 16, 2025

🚀 Preview for commit aca22aa at: https://67b18e68eb0cffee127bac5b--layer5.netlify.app

@vishalvivekm
Copy link
Contributor

@Fritozz-105
Thank you for your contribution!
Let's discuss this during the website call on Today at 7 AM CT | 6:30 PM IST
adding it as an agenda item to the meeting minutes.

@SAHU-01
Copy link
Contributor

SAHU-01 commented Feb 17, 2025

Thank you so much for working on this!!!

image @Fritozz-105 the alignment seems broken, we'd want to have centre aligned cards.

Additionally, @vishalvivekm suggests having coloured logos in light theme, could you ensure that's taken care of?

@Fritozz-105
Copy link
Author

Fritozz-105 commented Feb 17, 2025

@SAHU-01
Yes, I’ll try to get this taken care of. I’ll let you all know if I cannot.
I just have a question, it seems like there is an alignment issue on the production build of the website. Shall I fix that or would a separate issue be better?

@l5io
Copy link
Contributor

l5io commented Feb 19, 2025

🚀 Preview for commit 1ae8f1d at: https://67b657cdcb08e2ccc8624c5c--layer5.netlify.app

@l5io
Copy link
Contributor

l5io commented Feb 19, 2025

🚀 Preview for commit 47d25d2 at: https://67b667e8929937f17eb6bd97--layer5.netlify.app

Copy link
Contributor

@Vidit-Kushwaha Vidit-Kushwaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find the background color of black to be a little strange. What's your thought, @vishalvivekm?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Dark mode on the Interactive Labs page doesn't display the correct colors
5 participants