feat(components): Create TypingFilter component #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nebula-aac
added
pr/do-not-merge
aabidsofi19
reviewed
Dec 14, 2023
There was a problem hiding this comment.
@nebula-aac typo in name of file I is accidentally uppercase
aabidsofi19
reviewed
Dec 14, 2023
There was a problem hiding this comment.
@nebula-aac i think it would be more easier to understand the component if the state and utils go inside components/TypingFilter rather than in global utils .
|
@nebula-aac this looks great , you can rename the component to something else if you want . ( i didnt give much thought to giving a better name at the moment of creation ) |
fix #335 Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
nebula-aac
force-pushed
the
335-typing-filter
branch
from
fe724c3 to
d659025
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #335
Notes for Reviewers
This PR fixes #
Signed commits