Generate tests via hook_for :test_framework
#132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leverage the [`hook_for`](https://api.rubyonrails.org/classes/Rails/Generators/Base.html#method-c-hook_for) API to separate the test framework generation. This follows the rails pattern, and paves the way for adding other test framework templates (e.g. rspec). Along the way, move the `users.yml` fixture into a `fixtures` subfolder and convert the `copy_file` to a `template` for consistency.
Since we're using `template` for this file now, convert it to an actual template.
darronschall
force-pushed
the
use-hook-for-test-framework
branch
from
93e1121 to
3a64253
Compare
|
Really liked it, I'm just looking for time to take a look on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leverage the
hook_forAPI to separate the test framework generation. This follows the rails pattern, and paves the way for adding other test framework templates more easily (e.g. rspec that was started in #88).Along the way, move the
users.ymlfixture into afixturessubfolder and convert thecopy_fileto atemplatefor consistency.Note that that TestUnit generator repeats some
class_options, but only the ones that actually impact test generation. The only option test generation currently supports is--api.